gh-119396: Optimize unicode_decode_utf8_writer()#119957
Merged
vstinner merged 1 commit intopython:mainfrom Jun 3, 2024
Merged
Conversation
Take the ascii_decode() fast-path even if dest is not aligned on size_t bytes.
Member
Author
|
Benchmark (C part, _testcapimodule.c): static PyObject *
bench(PyObject *Py_UNUSED(module), PyObject *args)
{
const char *str;
Py_ssize_t loops;
if (!PyArg_ParseTuple(args, "ny", &loops, &str)) {
return NULL;
}
PyTime_t t1, t2;
(void)PyTime_PerfCounterRaw(&t1);
for (Py_ssize_t i=0; i < loops; i++) {
PyObject *obj = PyUnicode_FromFormat("=%s", str);
if (obj == NULL) {
return NULL;
}
Py_DECREF(obj);
}
(void)PyTime_PerfCounterRaw(&t2);
return PyFloat_FromDouble(PyTime_AsSecondsDouble(t2 - t1));
}Benchmark (Python part): import pyperf
import _testcapi
runner = pyperf.Runner()
arg = b'x' * 10
runner.bench_time_func("FromFormat('x'*10)", _testcapi.bench, arg)
arg = b'x' * 1_000
runner.bench_time_func("FromFormat('x'*1_000)", _testcapi.bench, arg)Result: |
vstinner
changed the title
mliezun
pushed a commit
to mliezun/cpython
that referenced
this pull request
Jun 3, 2024
Optimize unicode_decode_utf8_writer() Take the ascii_decode() fast-path even if dest is not aligned on size_t bytes.
barneygale
pushed a commit
to barneygale/cpython
that referenced
this pull request
Jun 5, 2024
Optimize unicode_decode_utf8_writer() Take the ascii_decode() fast-path even if dest is not aligned on size_t bytes.
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
Optimize unicode_decode_utf8_writer() Take the ascii_decode() fast-path even if dest is not aligned on size_t bytes.
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Optimize unicode_decode_utf8_writer() Take the ascii_decode() fast-path even if dest is not aligned on size_t bytes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take the ascii_decode() fast-path even if dest is not aligned on size_t bytes.