Skip to content

[2.7] bpo-32129: Avoid blurry IDLE application icon on macOS with Tk 8.6.#12034

Merged
ned-deily merged 1 commit intopython:2.7from
ned-deily:bpo-32129-idle-icon-macos-27
Mar 1, 2019
Merged

[2.7] bpo-32129: Avoid blurry IDLE application icon on macOS with Tk 8.6.#12034
ned-deily merged 1 commit intopython:2.7from
ned-deily:bpo-32129-idle-icon-macos-27

Conversation

@ned-deily
Copy link
Member

@ned-deily ned-deily commented Feb 25, 2019

Patch by Kevin Walzer.

https://bugs.python.org/issue32129

@ned-deily
Copy link
Member Author

ned-deily commented Feb 25, 2019

Note, we can't use the isAquaTk() check here on 2.7 because macosxSupport.setupApp hasn't been called yet to initialize things; in 3.x, the check no longer depends on the setup being called first. But just unconditionally skipping on macOS is fine since, when running under X on macOS, IDLE does not show up in the dock as a separate icon anyway.

Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot test on 2.7 but tested the 3.x patch and approve of you going ahead on this one.

@ned-deily ned-deily merged commit 453100f into python:2.7 Mar 1, 2019
@ned-deily ned-deily deleted the bpo-32129-idle-icon-macos-27 branch March 1, 2019 23:12
@ned-deily
Copy link
Member Author

@benjaminp, It would be great if you could cherrypick this into 2.7.16 final.

benjaminp pushed a commit that referenced this pull request Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants