bpo-36146: Don't run code at setup.py top level#12127
Merged
vstinner merged 1 commit intopython:masterfrom Mar 1, 2019
vstinner:refactor_setup_py6
Merged
bpo-36146: Don't run code at setup.py top level#12127vstinner merged 1 commit intopython:masterfrom vstinner:refactor_setup_py6
vstinner merged 1 commit intopython:masterfrom
vstinner:refactor_setup_py6
Conversation
* Move set_compiler_flags() calls and concurrent.future hack from module top-level to main() * Remove unused variables 'macros' and 'libraries' from detect_multiprocessing(). * Move SUMMARY and CLASSIFIERS constants at the top, move set_compiler_flags() function below these constants. * Add some empty new lines to respect PEP 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
module top-level to main()
detect_multiprocessing().
set_compiler_flags() function below these constants.
https://bugs.python.org/issue36146