bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set.#1272
bpo-30156: Fix a crash in debug build when PYTHONDUMPREFS is set.#1272serhiy-storchaka wants to merge 4 commits intopython:masterfrom
Conversation
Apply an alternate patch from bpo-26811.
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tim-one, @benjaminp and @tiran to be potential reviewers. |
vstinner
left a comment
There was a problem hiding this comment.
See discussion on the issue.
|
Excuse me, @Haypo, I have not understood what changes did you request. |
|
"See discussion on the issue." means see my comment on the issue: http://bugs.python.org/issue30156#msg292239 Basically, I asked if the optimization is worth it. |
|
To try and help move older pull requests forward, we are going through and backfilling 'awaiting' labels on pull requests that are lacking the label. Based on the current reviews, the best we can tell in an automated fashion is that a core developer requested changes to be made to this pull request. If/when the requested changes have been made, please leave a comment that says, |
|
I removed the optimization instead: PR #9541. |
Apply an alternate patch from bpo-26811.
https://bugs.python.org/issue30156