bpo-36577: setup.py reports missing OpenSSL again#12746
Merged
miss-islington merged 1 commit intopython:masterfrom Apr 9, 2019
Merged
bpo-36577: setup.py reports missing OpenSSL again#12746miss-islington merged 1 commit intopython:masterfrom
miss-islington merged 1 commit intopython:masterfrom
Conversation
bpo-36146 introduced another regression. In case of missing OpenSSL libraries or headers, setup.py no longer reported _hashlib and _ssl to be missing. Signed-off-by: Christian Heimes <[email protected]>
tiran
force-pushed
the
bpo-36577-setup-ssl
branch
from
ac404df to
d2f50f5
Compare
Member
Author
|
@xdegaye This is another regression. I found while I was verifying your PR. Thanks again! |
Member
Member
|
@tiran: I closed my PR. Your PR LGTM. |
Member
Author
|
Thanks @vstinner 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-36146 introduced another regression. In case of missing OpenSSL
libraries or headers, setup.py no longer reported _hashlib and _ssl to
be missing.
Signed-off-by: Christian Heimes [email protected]
https://bugs.python.org/issue36577