Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Thanks for your review, @encukou! I think I have addressed all of your comments and, as you anticipated, it simplifies things a great deal.

Would you mind taking another look?

Looks good now, thanks!
It does need a test. (Ideally comparing things to sys.maxsize and sysconfig.get_config_var, which should also serve as guide/validation for what the packaging tools will need to do for earlier Python versions.)

And, of course, it needs deciding on what should go here; but that's for the discussion thread.

Agreed about the tests and further discussion. I just wanted to stabilize the implementation sufficiently to be sure to write meaningful tests. Thanks again!

Tests are in place and easily extendable. Let's focus on the discussion and get this in 💪.

With the latest addition of comments on the Windows side of things, I think I addressed all comments. @AA-Turner apologies again for the rebase snafu. I hope a review is still doable.

🤖 New build scheduled with the buildbot fleet by @encukou for commit ed7b6d9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137476%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@encukou, I think the two test failures are unrelated to this PR (both from tarfile, fixed in #138626).

Is there anything left that I should do?

Could you add semantic Sphinx syntax for .. attribute::, from zklaus#3 ? Sorry I didn't link to it on Friday.

With that, I consider this good to merge :)

Done, thanks!

oops, I meant to push to my own branch to propose a PR to @zklaus's repo, sorry. Given Petr has enabled auto-merge already I'll propose my changes in a follow-up.

Separately, should we use a named type for abi_info? Currently the repr shows namespace, which could be surprising for users:

❯ .\python.bat
>>> import sys
>>> sys.abi_info
namespace(pointer_bits=64, free_threaded=False, debug=True, byteorder='little')

A

Separately, should we use a named type for abi_info?

I don't think that using namespace is a big deal here.

Congrats @zklaus, your PR was merged :-)

should we use a named type for abi_info?

sys.implementation is a namespace too, and I haven't seen any complaints.
(float_info and such are separate types with iter & getitem for compatibility with long-gone Pythons where these were tuples. The names are nice, but not worth the complexity for new stuff.)

I realised that one drawback of using SimpleNamespace is that the namespace is not immutable, unlike e.g. sys.version_info, sys.int_info, etc. I'm happy to continue using it given @vstinner & @encukou's comments, but perhaps we should override __setattr__? All the other _info namespaces in sys are immutable, sys.implementation seems to be the exception as far as I can tell.

A

No need. This is Python; consenting adults; you break it you get to keep the pieces; etc.

You can already set sys.int_info = type(sys.int_info)([5, 8, 23, 864]) for example.