bpo-29447: Add os.PathLike support to the tempfile module#1411
Closed
soolabettu wants to merge 1 commit intopython:masterfrom
Closed
bpo-29447: Add os.PathLike support to the tempfile module#1411soolabettu wants to merge 1 commit intopython:masterfrom
soolabettu wants to merge 1 commit intopython:masterfrom
Conversation
|
@svelankar, thanks for your PR! By analyzing the history of the files in this pull request, we identified @serhiy-storchaka, @gpshead and @tim-one to be potential reviewers. |
Member
|
Thanks for the PR, @svelankar , but after discussions on the issue about the appropriateness of my initial issue/idea, I'm going to close this as the wrong approach to take. Sorry if you feel like your time was wasted. 😢 |
Contributor
Author
|
No problem. Got to learn about PEP 519 and PEP 3119. So is the ticket 29447 to be closed or you are expecting a different approach and if its the latter, could you elaborate please ?Thanks. |
Member
|
@svelankar I updated bpo-29447 to more clearly specify what I'm thinking now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have updated classes TemporaryDirectory and _TemporaryFileWrapper. Not sure if it makes sense to add fspath to these classes - _RandomNameSequence, _TemporaryFileCloser and SpooledTemporaryFile.
Please review