Skip to content

bpo-20177: use builtin_dir to test METH_VARARGS#14330

Closed
jdemeyer wants to merge 1 commit intopython:masterfrom
jdemeyer:test_pycfunction_gmtime
Closed

bpo-20177: use builtin_dir to test METH_VARARGS#14330
jdemeyer wants to merge 1 commit intopython:masterfrom
jdemeyer:test_pycfunction_gmtime

Conversation

@jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Jun 24, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jun 24, 2019
@jdemeyer jdemeyer mentioned this pull request Jun 24, 2019
Closed
@vstinner
Copy link
Member

vstinner commented Jun 26, 2019

Maybe add a function to testcapi to not have to update tests each time the tested function uses a different calling convention.

pganssle
pganssle requested changes Jul 4, 2019
View reviewed changes
Copy link
Member

@pganssle pganssle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @vstinner, these tests are fragile because it seems they're testing incidental implementation details of these builtins that are not guaranteed.

Unless these properties are guaranteed for backwards-compatibility, I think replacing these with dedicated test functions with a guaranteed calling method is the right way to test it.

@bedevere-bot
Copy link

bedevere-bot commented Jul 4, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@jdemeyer jdemeyer closed this Jul 4, 2019
@larryhastings larryhastings mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle requested changes

Assignees

No one assigned

Labels

awaiting changes tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jdemeyer @vstinner @bedevere-bot @pganssle @the-knights-who-say-ni