Skip to content

Comments

[3.8] bpo-37732: Fix GCC warning in _PyObject_Malloc() (GH-15333)#15342

Merged
vstinner merged 1 commit intopython:3.8from
vstinner:pymalloc_alloc_warn38
Aug 20, 2019
Merged

[3.8] bpo-37732: Fix GCC warning in _PyObject_Malloc() (GH-15333)#15342
vstinner merged 1 commit intopython:3.8from
vstinner:pymalloc_alloc_warn38

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Aug 20, 2019 •
edited by bedevere-bot
Loading

pymalloc_alloc() now returns directly the pointer, return NULL on
memory allocation error.

allocate_from_new_pool() already uses NULL as marker for "allocation
failed".

(cherry picked from commit 18f8dcf)

https://bugs.python.org/issue37732

@vstinner
bpo-37732: Fix GCC warning in _PyObject_Malloc() (GH-15333)
6ae71ba 
pymalloc_alloc() now returns directly the pointer, return NULL on
memory allocation error.

allocate_from_new_pool() already uses NULL as marker for "allocation
failed".

(cherry picked from commit 18f8dcf)
@bedevere-bot bedevere-bot mentioned this pull request Aug 20, 2019
Merged
@vstinner vstinner merged commit 30e5aff into python:3.8 Aug 20, 2019
@vstinner vstinner deleted the pymalloc_alloc_warn38 branch August 20, 2019 12:44
@miss-islington
Copy link
Contributor

miss-islington commented Aug 20, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Aug 20, 2019

Sorry, @vstinner, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 30e5aff5fb0e3841107ddd4539a1f5b8521c80fb 3.7

@bedevere-bot
Copy link

bedevere-bot commented Aug 20, 2019

GH-15343 is a backport of this pull request to the 3.7 branch.

vstinner added a commit that referenced this pull request Aug 20, 2019
@vstinner
bpo-37732: Fix GCC warning in _PyObject_Malloc() (GH-15333) (GH-15342) (
c9a484a 
GH-15343)

pymalloc_alloc() now returns directly the pointer, return NULL on
memory allocation error.

allocate_from_new_pool() already uses NULL as marker for "allocation
failed".

(cherry picked from commit 18f8dcf)
(cherry picked from commit 30e5aff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @miss-islington @bedevere-bot @methane @the-knights-who-say-ni