[3.8] bpo-38304: Remove PyConfig.struct_size#16500
[3.8] bpo-38304: Remove PyConfig.struct_size#16500ncoghlan merged 1 commit intopython:3.8from vstinner:config_remove_struct_size
Conversation
vstinner
requested review from
a team,
brettcannon,
encukou,
ericsnowcurrently and
warsaw
as code owners
vstinner
changed the title
|
If this change is merged, it should be forward-ported to the master branch. |
|
See https://mail.python.org/archives/list/[email protected]/thread/C7Z2NA2DTM3DLOZCFQAK5A2WFYO3PHHX/ and https://bugs.python.org/issue38326 for the rationale and discussion. |
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
+1 from me. Leaves us time to discuss any further change without hurrying.
I'm a strong believer that a "stable ABI world" is possible... But we cannot implement everything today before 3.8.0rc1 final cut :-) It seems like we need more time to properly design the overall use story "provide a stable ABI for embedded Python". PyConfig is just a small piece. I didn't notice that vim is directly linked to libpython3.7.so for example. |
|
The "struct size" field didn't define a stable ABI, so it's moot anyway. |
ncoghlan
left a comment
ncoghlan
left a comment
There was a problem hiding this comment.
Thanks Victor. This update did convince that a stable embedding APi is more plausible than I previously thought it was, but just before an RC isn't the right time for us to be designing the initial pieces of that feature :)
For now, we'll rely on the fact that the config structures aren't covered by the stable ABI. We may revisit this in the future if we further explore the idea of offering a stable embedding API. (cherry picked from commit bdace21)
5 participants
https://bugs.python.org/issue38304