bpo-17393: do not convert import of non-package#16826
Closed
romuald wants to merge 1 commit intopython:mainfrom
Closed
bpo-17393: do not convert import of non-package#16826romuald wants to merge 1 commit intopython:mainfrom
romuald wants to merge 1 commit intopython:mainfrom
Conversation
In lib2to3, when a patched code is importing a module that has the same name as a local directory, check that it contains an __init__.py file before converting it to a local import Quick example: ``` fixtures/__init__.py fixtures/json/things.json ``` Previously `import json` was converted to `from . import json`
romuald
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
Member
|
I don't feel comfortable reviewing changes here. The other suggested reviewers might also not know too much about lib2to3; they were autoselected by the |
Member
|
Closed under bpo-45544. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lib2to3, when a patched code is importing a module that has the same
name as a local directory, check that it contains an
__init__.pyfilebefore converting it to a local import
Quick example:
Previously
import jsonwas converted tofrom . import jsonhttps://bugs.python.org/issue17393