bpo-38707: Fix for multiprocessing.Process MainThread.native_id#17088
Merged
miss-islington merged 9 commits intopython:masterfrom Nov 19, 2019
Merged
bpo-38707: Fix for multiprocessing.Process MainThread.native_id#17088miss-islington merged 9 commits intopython:masterfrom
miss-islington merged 9 commits intopython:masterfrom
Conversation
jaketesler
requested review from
a team,
1st1,
abalkin,
asvetlov,
berkerpeksag,
brettcannon,
encukou,
ericsnowcurrently,
ericvsmith,
gpshead,
gvanrossum,
ilevkivskyi,
methane,
ncoghlan,
pganssle,
rhettinger,
terryjreedy,
tiran,
vsajip and
warsaw
as code owners
jaketesler
force-pushed
the
fix-mp-native-id
branch
from
3816eee to
9bca1c8
Compare
Contributor
Author
|
Tests passed – ready to merge! @brandtbucher |
Member
|
CC @pitrou |
Contributor
Author
|
cc @vstinner |
pitrou
requested changes
Nov 13, 2019
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
LGTM except for one minor comment.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Contributor
Author
|
I didn't expect the Spanish Inquisition :) |
|
Nobody expects the Spanish Inquisition! @pitrou: please review the changes made to this pull request. |
Contributor
|
@jaketesler: Status check is done, and it's a success ✅ . |
Contributor
|
Thanks @jaketesler for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 19, 2019
…onGH-17088) This PR implements a fix for `multiprocessing.Process` objects; the error occurs when Processes are created using either `fork` or `forkserver` as the `start_method`. In these instances, the `MainThread` of the newly created `Process` object retains all attributes from its parent's `MainThread` object, including the `native_id` attribute. The resulting behavior is such that the new process' `MainThread` captures an incorrect/outdated `native_id` (the parent's instead of its own). This change forces the Process object to update its `native_id` attribute during the bootstrap process. cc @vstinner https://bugs.python.org/issue38707 Automerge-Triggered-By: @pitrou (cherry picked from commit c6b20be) Co-authored-by: Jake Tesler <[email protected]>
|
GH-17261 is a backport of this pull request to the 3.8 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 19, 2019
…7088) This PR implements a fix for `multiprocessing.Process` objects; the error occurs when Processes are created using either `fork` or `forkserver` as the `start_method`. In these instances, the `MainThread` of the newly created `Process` object retains all attributes from its parent's `MainThread` object, including the `native_id` attribute. The resulting behavior is such that the new process' `MainThread` captures an incorrect/outdated `native_id` (the parent's instead of its own). This change forces the Process object to update its `native_id` attribute during the bootstrap process. cc @vstinner https://bugs.python.org/issue38707 Automerge-Triggered-By: @pitrou (cherry picked from commit c6b20be) Co-authored-by: Jake Tesler <[email protected]>
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
…onGH-17088) This PR implements a fix for `multiprocessing.Process` objects; the error occurs when Processes are created using either `fork` or `forkserver` as the `start_method`. In these instances, the `MainThread` of the newly created `Process` object retains all attributes from its parent's `MainThread` object, including the `native_id` attribute. The resulting behavior is such that the new process' `MainThread` captures an incorrect/outdated `native_id` (the parent's instead of its own). This change forces the Process object to update its `native_id` attribute during the bootstrap process. cc @vstinner https://bugs.python.org/issue38707 Automerge-Triggered-By: @pitrou
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…onGH-17088) This PR implements a fix for `multiprocessing.Process` objects; the error occurs when Processes are created using either `fork` or `forkserver` as the `start_method`. In these instances, the `MainThread` of the newly created `Process` object retains all attributes from its parent's `MainThread` object, including the `native_id` attribute. The resulting behavior is such that the new process' `MainThread` captures an incorrect/outdated `native_id` (the parent's instead of its own). This change forces the Process object to update its `native_id` attribute during the bootstrap process. cc @vstinner https://bugs.python.org/issue38707 Automerge-Triggered-By: @pitrou
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a fix for
multiprocessing.Processobjects; the error occurs when Processes are created using eitherforkorforkserveras thestart_method.In these instances, the
MainThreadof the newly createdProcessobject retains all attributes from its parent'sMainThreadobject, including thenative_idattribute. The resulting behavior is such that the new process'MainThreadcaptures an incorrect/outdatednative_id(the parent's instead of its own).This change forces the Process object to update its
native_idattribute during the bootstrap process.cc @vstinner
https://bugs.python.org/issue38707
Automerge-Triggered-By: @pitrou