Remove binding of captured exceptions when not used to reduce the chances of creating cycles#17246
Merged
pablogsal merged 1 commit intopython:masterfrom Nov 19, 2019
Merged
Conversation
pablogsal
requested review from
abalkin,
pganssle,
rhettinger and
skrah
as code owners
pablogsal
force-pushed
the
no_cycles
branch
2 times, most recently
from
d204951 to
39bbd92
Compare
pablogsal
requested review from
brettcannon,
encukou,
ericsnowcurrently,
gpshead,
gvanrossum,
ilevkivskyi,
ncoghlan,
tiran,
vsajip and
warsaw
as code owners
pablogsal
force-pushed
the
no_cycles
branch
2 times, most recently
from
126e2c9 to
d204951
Compare
pablogsal
removed request for
1st1,
abalkin,
asvetlov,
encukou,
ericsnowcurrently,
gvanrossum,
ilevkivskyi,
ncoghlan,
pganssle,
rhettinger,
skrah,
tiran,
vsajip and
warsaw
…nces of creating cycles
Member
Author
|
Apologies for the noise regarding the review list, I don't know why GitHub reacted like that :( |
brettcannon
approved these changes
Nov 19, 2019
gvanrossum
approved these changes
Nov 19, 2019
Member
Author
|
Thanks for the review! |
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
…nces of creating cycles (pythonGH-17246) Capturing exceptions into names can lead to reference cycles though the __traceback__ attribute of the exceptions in some obscure cases that have been reported previously and fixed individually. As these variables are not used anyway, we can remove the binding to reduce the chances of creating reference cycles. See for example pythonGH-13135
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
…nces of creating cycles (pythonGH-17246) Capturing exceptions into names can lead to reference cycles though the __traceback__ attribute of the exceptions in some obscure cases that have been reported previously and fixed individually. As these variables are not used anyway, we can remove the binding to reduce the chances of creating reference cycles. See for example pythonGH-13135
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capturing exceptions into names can lead to reference cycles though the
__traceback__attribute of the exceptions in some obscure cases that have been reported previously and fixed individually. As these variables are not used anyway, we can remove the binding to reduce the chances of creating reference cycles.See for example: #13135