Skip to content

Comments

bpo-38324: Skip locale tests which fail on Windows#18403

Closed
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:test_locale_windows
Closed

bpo-38324: Skip locale tests which fail on Windows#18403
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:test_locale_windows

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 7, 2020

@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #18403 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18403      +/-   ##
==========================================
- Coverage   83.25%   83.19%   -0.06%     
==========================================
  Files        1570     1570              
  Lines      414397   414400       +3     
  Branches    44429    44430       +1     
==========================================
- Hits       344993   344761     -232     
- Misses      59758    59992     +234     
- Partials     9646     9647       +1     
Impacted Files Coverage Δ
Lib/distutils/tests/test_bdist_rpm.py 30.00% <0.00%> (-65.00%) ⬇️
Lib/distutils/command/bdist_rpm.py 7.63% <0.00%> (-56.88%) ⬇️
Lib/test/test_urllib2net.py 76.92% <0.00%> (-13.85%) ⬇️
Lib/test/test_smtpnet.py 78.57% <0.00%> (-7.15%) ⬇️
Lib/ftplib.py 63.85% <0.00%> (-6.06%) ⬇️
Lib/test/test_ftplib.py 87.11% <0.00%> (-4.72%) ⬇️
Tools/scripts/db2pickle.py 17.82% <0.00%> (-3.97%) ⬇️
Tools/scripts/pickle2db.py 16.98% <0.00%> (-3.78%) ⬇️
Lib/test/test_socket.py 71.94% <0.00%> (-3.77%) ⬇️
Lib/test/test_asyncio/test_base_events.py 91.84% <0.00%> (-3.30%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10dc3e...99687b3. Read the comment docs.

@vstinner
Copy link
Member Author

This PR only hides real issues. It would be better to fix issues.

@vstinner vstinner closed this Feb 10, 2020
@vstinner vstinner deleted the test_locale_windows branch February 10, 2020 23:16
w-hsiung added a commit to w-hsiung/cpython that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants