bpo-38691: Ignore pythoncaseok tests#18627
Merged
vstinner merged 7 commits intopython:masterfrom Mar 9, 2020
Merged
Conversation
Member
That's why the PR #18314 was reverted: https://bugs.python.org/issue38691#msg362202 |
Contributor
Author
|
@vstinner ready for review |
Codecov Report
@@ Coverage Diff @@
## master #18627 +/- ##
===========================================
+ Coverage 82.13% 83.22% +1.09%
===========================================
Files 1955 1571 -384
Lines 584601 415387 -169214
Branches 44484 44488 +4
===========================================
- Hits 480156 345709 -134447
+ Misses 94793 60029 -34764
+ Partials 9652 9649 -3
Continue to review full report at Codecov.
|
vstinner
reviewed
Mar 2, 2020
| @@ -0,0 +1 @@ | |||
| Updated :meth:`importlib._bootstrap_external._make_relax_case` to ignore :envvar:`PYTHONCASEOK` when -E or -I flags are used. No newline at end of file | |||
Member
There was a problem hiding this comment.
I would prefer to avoid mentioning a private module (_bootstrap_external) in a public Changelog entry. Reuse the text that you wrote above:
The :mod:`importlib` module now ignores the :envvar:`PYTHONCASEOK`
environment variable when the :option:`-E` or :option:`-I` command line
options are being used.
Member
|
Thanks, merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-38691 Ignore pythoncaseok tests
[3.9] bpo-38691 Added a switch to ignore PYTHONCASEOK when -E or -I flags passed (GH-18627)
https://bugs.python.org/issue38691