bpo-40221: Update ForkAwareThreadLock to use _at_fork_reinit#19477
Merged
corona10 merged 2 commits intopython:masterfrom Apr 14, 2020
Merged
bpo-40221: Update ForkAwareThreadLock to use _at_fork_reinit#19477corona10 merged 2 commits intopython:masterfrom
corona10 merged 2 commits intopython:masterfrom
Conversation
vstinner
reviewed
Apr 13, 2020
| @@ -0,0 +1 @@ | |||
| Update ForkAwareThreadLock to use _at_fork_reinit. | |||
Member
There was a problem hiding this comment.
For such news entry, you should mention which module is modified. The user reading the NEWS entry has no idea, except maybe multiprocessing experts ;-)
For this specific change, honestly, I don't think that end users really care: I suggest to remove the NEWS entry. The change doesn't seem to fix any known crash, it's more a cleanup/refactoring.
vstinner
approved these changes
Apr 14, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM if you remove the NEWS entry. But I also suggest to mention somehow multiprocessing in the commit message.
Member
|
Commit message: for example, " bpo-40221: Update multiprocessing to use _at_fork_reinit". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40221