bpo-30547: Fix multiple reference leaks#1995
Merged
vstinner merged 1 commit intopython:masterfrom Jun 8, 2017
Merged
Conversation
vstinner
reviewed
Jun 8, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
In the commit message, can you please use the syntax:
Co-Authored-By: full name <[email protected]>
Rather than GitHub names? For me, it's:
Co-Authored-By: Victor Stinner <[email protected]>
vstinner
reviewed
Jun 8, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Commit message:
"Introduced by 1abcf67"
Hum, it was also introduced by 6b4be19. I propose:
Fix regressions introduced by:
- bpo-18520: commit 8fea252a507024edf00d5d98881d22dc8799a8d3
- bpo-22257: commits 1abcf6700b4da6207fe859de40c6c1bada6b4fec and 6b4be195cd8868b76eb6fbe166acc39beee8ce36
vstinner
approved these changes
Jun 8, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, let's see if all tests pass ;-)
vstinner
requested changes
Jun 8, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I suggest you to revert the warnoptions change and let it open, since it seems tricky to fix it.
Python/sysmodule.c
Outdated
Member
There was a problem hiding this comment.
test_capi does crash with this change :-(
Fix regressions introduced by: - bpo-22257: commits 1abcf67 and 6b4be19 Co-Authored-By: Victor Stinner <[email protected]> Co-Authored-By: Louie Lu <[email protected]>
vstinner
approved these changes
Jun 8, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Ok, it should now pass on Travis CI but it doesn't fix the refleak in warnoptions. It's a compromise :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regressions introduced by:
Fixed with @Haypo and @mlouielu