Skip to content

Comments

[3.9] bpo-40910: Export Py_GetArgcArgv() function (GH-20721)#20723

Merged
vstinner merged 1 commit intopython:3.9from
vstinner:get_argc_argv39
Jun 8, 2020
Merged

[3.9] bpo-40910: Export Py_GetArgcArgv() function (GH-20721)#20723
vstinner merged 1 commit intopython:3.9from
vstinner:get_argc_argv39

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 8, 2020

Export explicitly the Py_GetArgcArgv() function to the C API and
document the function. Previously, it was exported implicitly which
no longer works since Python is built with -fvisibility=hidden.

  • Add PyConfig._orig_argv member.
  • Py_InitializeFromConfig() no longer calls _PyConfig_Write() twice.
  • PyConfig_Read() no longer initializes Py_GetArgcArgv(): it is now
    _PyConfig_Write() responsibility.
  • _PyConfig_Write() result type becomes PyStatus instead of void.
  • Write an unit test on Py_GetArgcArgv().

(cherry picked from commit e81f6e6)

https://bugs.python.org/issue40910

Export explicitly the Py_GetArgcArgv() function to the C API and
document the function. Previously, it was exported implicitly which
no longer works since Python is built with -fvisibility=hidden.

* Add PyConfig._orig_argv member.
* Py_InitializeFromConfig() no longer calls _PyConfig_Write() twice.
* PyConfig_Read() no longer initializes Py_GetArgcArgv(): it is now
  _PyConfig_Write() responsibility.
* _PyConfig_Write() result type becomes PyStatus instead of void.
* Write an unit test on Py_GetArgcArgv().

(cherry picked from commit e81f6e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants