bpo-40958: Avoid 'possible loss of data' build warning on Windows#20968
Closed
lysnikolaou wants to merge 1 commit intopython:masterfrom
Closed
bpo-40958: Avoid 'possible loss of data' build warning on Windows#20968lysnikolaou wants to merge 1 commit intopython:masterfrom
lysnikolaou wants to merge 1 commit intopython:masterfrom
Conversation
pablogsal
reviewed
Jun 18, 2020
|
|
||
| return Constant(c, NULL, t->lineno, t->col_offset, t->end_lineno, t->end_col_offset, | ||
| p->arena); | ||
| return Constant(c, NULL, (int) t->lineno, (int) t->col_offset, (int) t->end_lineno, |
Member
There was a problem hiding this comment.
Ugh..... I am not a fan of having to do these castings everywhere. I think we should either revert the Py_ssize_t change or adapt the AST C types to use Py_ssize_t instead of integers for these attributes. What do you think?
Member
Author
There was a problem hiding this comment.
Agreed. I'm not sure what I would go with. Probably just revert the Py_ssize_ts in the Token struct.
Member
There was a problem hiding this comment.
Yeah, I think that would be better for now. I will investigate how much would entail adapting the AST structs, but that likely will need more discussion with other core devs, because it will affect downstream code.
Member
Author
There was a problem hiding this comment.
Right! I'll close this PR then and open a new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40958