Skip to content

bpo-41938: fixed wait calling len on iterables#22555

Closed
rohitkg98 wants to merge 1 commit intopython:mainfrom
rohitkg98:fix-issue-41938
Closed

bpo-41938: fixed wait calling len on iterables#22555
rohitkg98 wants to merge 1 commit intopython:mainfrom
rohitkg98:fix-issue-41938

Conversation

@rohitkg98
Copy link

@rohitkg98 rohitkg98 commented Oct 5, 2020

concurrent.futures.wait was calling len() on possible iterables and we were converting the argument to set anyways. so just changed it to set from start.
checkout this issue41938 for more details.

https://bugs.python.org/issue41938

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@rohitkg98

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is already in 3.11.0.a4.
But I don't see any test associated with the change.

@hauntsaninja
Copy link
Contributor

Thanks for this contribution, however, it looks like it was already fixed in #30168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants