Skip to content

bpo-42517: [Enum] do not convert private names into members#23722

Merged
ethanfurman merged 2 commits intopython:masterfrom
ethanfurman:enum-private-non-member
Dec 10, 2020
Merged

bpo-42517: [Enum] do not convert private names into members#23722
ethanfurman merged 2 commits intopython:masterfrom
ethanfurman:enum-private-non-member

Conversation

@ethanfurman
Copy link
Member

@ethanfurman ethanfurman commented Dec 9, 2020

@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-23748 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 13, 2020
…-23722)

private names, such as `_Color__hue` and `_Color__hue_` are now normal attributes, and do not become members nor raise exceptions
(cherry picked from commit 7cf0aad)

Co-authored-by: Ethan Furman <[email protected]>
ethanfurman pushed a commit that referenced this pull request Dec 14, 2020
…-23748)

private names will raise a DeprecationWarning; in 3.10 they will become normal attributes
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…-23722)

private names, such as `_Color__hue` and `_Color__hue_` are now normal attributes, and do not become members nor raise exceptions
@ethanfurman ethanfurman deleted the enum-private-non-member branch April 15, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants