bpo-27200: fix configparser, copyreg and ctypes doctests#240
bpo-27200: fix configparser, copyreg and ctypes doctests#240berkerpeksag merged 3 commits intopython:masterfrom marco-buttu:fix-issue-27200
Conversation
Doc/library/configparser.rst
Outdated
|
|
||
| .. testsetup:: | ||
|
|
||
| import configparser |
There was a problem hiding this comment.
Indentation should use three spaces here.
There was a problem hiding this comment.
Thanks, you are right
Doc/library/ctypes.rst
Outdated
| accessing it repeatedly returns the same object each time. On the other hand, | ||
| accessing it through an index returns a new object each time: | ||
|
|
||
| .. doctest:: |
There was a problem hiding this comment.
I find your version much clearer, +1. However, I don't see much point converting this to a doctest. I'd say remove .. doctest:: and keep the rest of the changes.
There was a problem hiding this comment.
I removed the doctest directive. However, there is one point for taking it: in some editors, if you use the :: before the example you enable the syntax hightligh for the example, but the example will not be doctested. If you use just the :, you lose the syntax highligh but the example will be doctested. If you eventually use the doctest directive, you have both syntax highlight and doctest.
There was a problem hiding this comment.
Well, I didn't mentioned it because I assumed you are going to change "[...] each time:" to "[...] each time::" :)
There was a problem hiding this comment.
@berkerpeksag, it was "[...] each time:" from the beginning, I did not change it. Do you still want to change it anyway? Sorry for all these questions :/
There was a problem hiding this comment.
Yes, please change it to "[...] each time::".
There was a problem hiding this comment.
Ok, done. Thank you! :-)
Bumps [pytest](https://github.com/pytest-dev/pytest) from 4.5.0 to 4.6.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@4.5.0...4.6.1)
4 participants
This PR patially fixes bpo-27200. Partially and not completely, because I followed the suggestion of @ezio-melotti to split the patch in several patches. According to @rhettinger I applyed minimal changes, skipping some tests instead of using
sorted(). I just want to point out that the two<BLANKLINE>and thetestsetupdicrective will not appear in the output.