bpo-30764: Windows support.SuppressCrashReport#2423
Merged
vstinner merged 1 commit intopython:2.7from Jun 27, 2017
vstinner:suppress_crash_win27
Merged
bpo-30764: Windows support.SuppressCrashReport#2423vstinner merged 1 commit intopython:2.7from vstinner:suppress_crash_win27
vstinner merged 1 commit intopython:2.7from
vstinner:suppress_crash_win27
Conversation
* Add Windows support to test.support.SuppressCrashReport: call SetErrorMode() and CrtSetReportMode(). * _testcapi: add CrtSetReportMode() and CrtSetReportFile() functions and CRT_xxx and CRTDBG_xxx constants needed by SuppressCrashReport.
Member
Author
|
I tried to implement a pure ctypes version but failed: see http://bugs.python.org/issue30764#msg296965 IMHO this PR is more reliable. |
Member
Author
|
cc @eryksun |
Member
Author
|
This PR will allow to fix http://bugs.python.org/issue30705 |
Member
|
Don't we already have these functions in |
Member
Author
None of the added functions or constants is already available in msvcrt. Otherwise, I would just use them ;-) Reminder: Python 2.7 was released 7 years ago. A lot of things evolved in Python 3 in the meanwhile ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetErrorMode() and CrtSetReportMode().
and CRT_xxx and CRTDBG_xxx constants needed by SuppressCrashReport.