bpo-43244: Move pyarena.h from include/cpython to include/internal/.#24688
bpo-43244: Move pyarena.h from include/cpython to include/internal/.#24688shihai1991 wants to merge 1 commit intopython:masterfrom
Conversation
shihai1991
requested review from
a team,
isidentical,
lysnikolaou,
markshannon and
pablogsal
as code owners
shihai1991
changed the title
shihai1991
force-pushed
the
bpo_43244
branch
2 times, most recently
from
be8eda6 to
5fefa0a
Compare
|
Isn't |
IIRC, no limited apis store in |
shihai1991
changed the title
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Include/Python-ast.h is blocking this PR.
|
|
||
| #ifndef Py_LIMITED_API | ||
| #include "asdl.h" | ||
| #include "pycore_arena.h" |
There was a problem hiding this comment.
This is a blocker issue. You must not include an internal header file in a public header file. So I understand that if we want to implement https://bugs.python.org/issue43244 we should first move Python-ast.h to the internal C API.
There was a problem hiding this comment.
You must not include an internal header file in a public header file.
Oh, got it. I haven't pay attention to this detail before.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I'm reworking the code base to be able to solve https://bugs.python.org/issue43244 But this PR is incorrect, so I close it. I may rewrite it. But other stuff should be done before (like moving Python-ast.h). |
5 participants
https://bugs.python.org/issue43244