bpo-25643: Refactor the C tokenizer#25050
Conversation
pablogsal
force-pushed
the
better_token
branch
3 times, most recently
from
f57fa09 to
068e38a
Compare
There was a problem hiding this comment.
@pablogsal, @serhiy-storchaka: I added some PEP 7 comments, some comments about deprecated memory functions, and some decref / free control questions. Hope you don't mind.
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Thanks a lot for your comments and for the review. I have applied most of the PEP7 and made some changes to error returning paths so they are a bit more clear. Regarding PEP7, normally we only adapt it when we are reworking things, but given that this change was quite big I had opted to not make it worse by changing the surrounding style, but I think it doesn't hurt that much. |
|
@erlend-aasland Once you are ok with the changes, you can approve the PR if you wish :) |
Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland
left a comment
erlend-aasland
left a comment
There was a problem hiding this comment.
@erlend-aasland Once you are ok with the changes, you can approve the PR if you wish :)
LGTM :)
4 participants
https://bugs.python.org/issue25643
Based on the original patch by Serhiy Storchaka