Skip to content

bpo-43682: @staticmethod inherits attributes#25268

Merged
vstinner merged 3 commits intopython:masterfrom
vstinner:wraps_staticmethod
Apr 9, 2021
Merged

bpo-43682: @staticmethod inherits attributes#25268
vstinner merged 3 commits intopython:masterfrom
vstinner:wraps_staticmethod

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Apr 7, 2021 •
edited
Loading

Static methods (@staticmethod) and class methods (@classmethod) now
inherit the method attributes (module, name, qualname,
doc, annotations) and have a new wrapped attribute.

Changes:

  • Add a repr() method to staticmethod and classmethod types.
  • Add tests on the @classmethod decorator.

https://bugs.python.org/issue43682

@vstinner
Copy link
Member Author

vstinner commented Apr 7, 2021

functools_wraps() call in cm_init() failed because Python didn't initialize PyClassMethod_Type type at startup. I created https://bugs.python.org/issue43770 to fix the issue: it's now fixed by df5dc1c

@vstinner
Copy link
Member Author

vstinner commented Apr 7, 2021

I chose the following representation:

$ ./python -q
>>> def func(): pass
... 
>>> staticmethod(func)
<staticmethod(<function func at 0x7f39e8152c50>)>
>>> classmethod(func)
<classmethod(<function func at 0x7f39e8152c50>)>

@vstinner
bpo-43682: @staticmethod inherits method attributes
b50eb07 
Static methods (@staticmethod) and class methods (@classmethod) now
inherit the method attributes (__module__, __name__, __qualname__,
__doc__, __annotations__) and have a new __wrapped__ attribute.

Changes:

* Add a repr() method to staticmethod and classmethod types.
* Add tests on the @classmethod decorator.
@vstinner
Copy link
Member Author

vstinner commented Apr 7, 2021

cc @serhiy-storchaka

@vstinner vstinner mentioned this pull request Apr 8, 2021
Merged
@vstinner vstinner merged commit 507a574 into python:master Apr 9, 2021
@vstinner vstinner deleted the wraps_staticmethod branch April 9, 2021 15:51
AlexWaygood added a commit to AlexWaygood/typeshed that referenced this pull request Nov 12, 2021
@AlexWaygood
Add __name__/__qualname__/__wrapped__ to staticmethod/`classm…
0d22fe9 
…ethod`

These attributes have all been added in Python 3.10+; see python/cpython#25268
@AlexWaygood AlexWaygood mentioned this pull request Nov 12, 2021
Merged
@scottcwang scottcwang mentioned this pull request Jan 27, 2022
Closed
@vstinner vstinner mentioned this pull request Jun 23, 2022
Closed
@geryogam
Copy link
Contributor

geryogam commented May 21, 2023

@vstinner What’s this new __wrapped__ attribute? Is it the same as the existing __func__ attribute? If so, why did you introduce it?

@carljm
Copy link
Member

carljm commented May 21, 2023

What’s this new __wrapped__ attribute? Is it the same as the existing __func__ attribute? If so, why did you introduce it?

It's a standard attribute added by functools.wraps to wrapper functions allowing unwrapping back to the wrapped function (eg by inspect.unwrap). So it's generally useful for wrappers to set it.

@geryogam
Copy link
Contributor

geryogam commented May 21, 2023

@carljm Thanks, so I guess in this case it’s a documented duplicate of __func__ which is an undocumented attribute.

serhiy-storchaka
serhiy-storchaka reviewed Jul 1, 2023
View reviewed changes
Objects/funcobject.c
Comment on lines +721 to +724
PyObject *value = PyObject_GetAttr(wrapped, name);
if (value == NULL) {
if (PyErr_ExceptionMatches(PyExc_AttributeError)) {
PyErr_Clear();
Copy link
Member

@serhiy-storchaka serhiy-storchaka Jul 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to use _PyObject_LookupAttr() here. See #106303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner @geryogam @carljm @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot