bpo-43868: Remove PyOS_ReadlineFunctionPointer from the stable ABI list#25442
Merged
encukou merged 3 commits intopython:masterfrom Apr 23, 2021
Merged
bpo-43868: Remove PyOS_ReadlineFunctionPointer from the stable ABI list#25442encukou merged 3 commits intopython:masterfrom
encukou merged 3 commits intopython:masterfrom
Conversation
The inclusion of PyOS_ReadlineFunctionPointer in python3dll.c was a mistake. According to PEP 384: > functions expecting FILE* are not part of the ABI, to avoid depending > on a specific version of the Microsoft C runtime DLL on Windows.
vstinner
approved these changes
Apr 16, 2021
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM: https://bugs.python.org/issue43868#msg391237
I just propose to mention the change in What's New in Python 3.10.
| @@ -0,0 +1,3 @@ | |||
| :c:func:`PyOS_ReadlineFunctionPointer` is no longer exported by | |||
Member
There was a problem hiding this comment.
Do you think that it's worth it to be mentioned in C API Changes of What's New in Python 3.10?
https://docs.python.org/dev/whatsnew/3.10.html#id2 ?
Member
Author
There was a problem hiding this comment.
Yes, that sounds reasonable. Thanks for the catch!
vstinner
approved these changes
Apr 20, 2021
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the What's New entry ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inclusion of PyOS_ReadlineFunctionPointer in python3dll.c was a mistake.
According to PEP 384:
https://bugs.python.org/issue43868