bpo-30570: fix an issubclass infinite recursion crash#29017
Closed
gpshead wants to merge 1 commit intopython:mainfrom
Closed
bpo-30570: fix an issubclass infinite recursion crash#29017gpshead wants to merge 1 commit intopython:mainfrom
gpshead wants to merge 1 commit intopython:mainfrom
Conversation
values code emits for `__bases__`.
Member
Author
|
While this appears to work, I'd like to see the python benchmark suite run with it to make sure it doesn't have a notable performance impact. there are faster implementation alternatives. even just storing the visited pointers in a linear C array that we realloc when it needs to grow and doing a linear search in that or keeping it sorted for faster than O(n) lookup would be sufficient and waay less complex than using the PySet code. |
gpshead
changed the title
gpshead
added
needs backport to 3.10
Member
Author
|
#29048 is much simpler and nicer than this one. closing. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issubclass()could crash due to infinite recursion on the values user supplied code emits for__bases__.https://bugs.python.org/issue30570