Experimental variant of BINARY_ADD specialization.#29059
Closed
markshannon wants to merge 4 commits intopython:mainfrom
Closed
Experimental variant of BINARY_ADD specialization.#29059markshannon wants to merge 4 commits intopython:mainfrom
markshannon wants to merge 4 commits intopython:mainfrom
Conversation
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
I wonder if we'll see any speedups from this. I don't see how it will be much faster than PyNumber_Add. If the compiler's smart about it, it'll probably inline PyNumber_Add during PGO, and we'll have almost the same function
Comment on lines
+2205
to
+2206
| Py_DECREF(sum); | ||
| sum = NULL; |
Member
There was a problem hiding this comment.
You may want to consider replacing this with
Suggested change
| Py_DECREF(sum); | |
| sum = NULL; | |
| Py_SETREF(sum, NULL); |
Member
There was a problem hiding this comment.
Or:
Suggested change
| Py_DECREF(sum); | |
| sum = NULL; | |
| Py_CLEAR(sum); |
Member
Author
Member
Author
|
Will need reworking once #29482 is merged. |
Member
Author
|
@brandtbucher Maybe something like this will show better results now that the binary and inplace operators have been merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.