bpo-46355: What's New: Note that PyFrameObject are private#31032
Merged
miss-islington merged 1 commit intopython:mainfrom Feb 1, 2022
Merged
bpo-46355: What's New: Note that PyFrameObject are private#31032miss-islington merged 1 commit intopython:mainfrom
miss-islington merged 1 commit intopython:mainfrom
Conversation
This adds a slightly more detailed explanation of the change. The most important point is that the changed/removed fields were "subject to change" to begin with.
vstinner
approved these changes
Jan 31, 2022
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. You're right, it's good to remind that the structure is "private".
Member
|
A few lines below, there is "Changes of the PyThreadState structure members". IMO this structure is also private. At least, @markshannon and me want to make it opaque :-) |
Member
Author
|
Feel free to send a similar PR. |
raghavthind2005
approved these changes
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a slightly more detailed explanation of the change.
The most important point is that the changed/removed fields
were "subject to change" to begin with.
https://bugs.python.org/issue46355
Automerge-Triggered-By: GH:encukou