bpo-47009: Let PRECALL_NO_KW_LIST_APPEND do its own POP_TOP#32239
Merged
markshannon merged 3 commits intopython:mainfrom Apr 5, 2022
Merged
bpo-47009: Let PRECALL_NO_KW_LIST_APPEND do its own POP_TOP#32239markshannon merged 3 commits intopython:mainfrom
markshannon merged 3 commits intopython:mainfrom
Conversation
43782cc to
e0adb6a
Compare
Member
|
Looks good. I'm a bit wary of specialized superinstructions, but this seems solid. |
Member
|
The assert is failing on s390x Fedora buildbot https://buildbot.python.org/all/#/builders/232/builds/524 |
Member
|
Strange. The bytecode is exactly the same on all platforms. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most code won't do
y = L.append(x)or whatnot, soPRECALL_NO_KW_LIST_APPENDis almost always followed byPOP_TOP. We can verify at specialization time.This saves a
Py_INCREF(Py_None), aSET_TOP(Py_None), and POP_TOP'sPy_DECREF(POP()); DISPATCH();.Some microbenchmarks:
From GCC, --enable-optimizations, --with-lto:
https://bugs.python.org/issue47009