bpo-31641: Allow arbitrary iterables in concurrent.futures.as_completed()#3830
Merged
ambv merged 1 commit intopython:masterfrom Sep 29, 2017
Merged
bpo-31641: Allow arbitrary iterables in concurrent.futures.as_completed()#3830ambv merged 1 commit intopython:masterfrom
concurrent.futures.as_completed()#3830ambv merged 1 commit intopython:masterfrom
Conversation
…ted()` This was possible before. pythonGH-1560 introduced a regression after 3.6.2 got released where only sequences were accepted now. This commit addresses this problem.
ambv
added
skip news
needs backport to 3.6
type-bug
Contributor
Author
|
News entry not required because this reverts a regression before a release was made. |
Contributor
Author
|
@ned-deily This is a release blocker for 3.6.3, please make sure to merge it. We'll probably want RC2 because of this? |
pitrou
approved these changes
Sep 29, 2017
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thanks for noticing and for the quick fix!
Contributor
|
Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-3831 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 29, 2017
…completed()` (pythonGH-3830) This was possible before. pythonGH-1560 introduced a regression after 3.6.2 got released where only sequences were accepted now. This commit addresses this problem. (cherry picked from commit 574562c)
Member
|
Re: "We'll probably want [3.6.3] RC2 because of this?" We could and normally would but this change seems isolated enough and simple enough that, unless someone has a strong objection, I'm inclined to just cherry pick it into 3.6.3 final unless some other, more intrusive change comes along to trigger a second RC. |
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Oct 3, 2017
…completed()` (pythonGH-3830) (python#3831) This was possible before. pythonGH-1560 introduced a regression after 3.6.2 got released where only sequences were accepted now. This commit addresses this problem. (cherry picked from commit 574562c)
dalcinl
added a commit
to dalcinl/pythonfutures
that referenced
this pull request
Oct 3, 2017
agronholm
pushed a commit
to agronholm/pythonfutures
that referenced
this pull request
Nov 29, 2017
This was referenced May 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was possible before. GH-1560 introduced a regression after 3.6.2 got
released where only sequences were accepted now. This commit addresses this
problem.
https://bugs.python.org/issue31641