bpo-30156: Remove property_descr_get() hack#3985
Closed
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:property_fastcall
Closed
bpo-30156: Remove property_descr_get() hack#3985vstinner wants to merge 1 commit intopython:masterfrom vstinner:property_fastcall
vstinner wants to merge 1 commit intopython:masterfrom
vstinner:property_fastcall
Conversation
Remove the cached tuple which caused crashed, use
_PyObject_FastCall() instead.
Microbenchmark using:
./python -m perf timeit
-s 'import collections;P=collections.namedtuple("P","x y");p=P(1, 2)'
'p.x'
[ref] 80.4 ns +- 3.3 ns -> [fastcall] 103 ns +- 5 ns: 1.28x slower (+28%)
Member
Author
|
What do you think of this bugfix @serhiy-storchaka? Is it an acceptable slowdown to avoid any crash in this code? I prefer to not play with the devil: reference counts and garbage collector. |
Member
Author
|
Ping @serhiy-storchaka: would you be ok to remove the optimization to fix the bug, and prevent future other bugs in corner cases? |
Member
|
There are ways of fixing a bug without hitting the performance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the cached tuple which caused crashed, use
_PyObject_FastCall() instead.
Microbenchmark using:
[ref] 80.4 ns +- 3.3 ns -> [fastcall] 103 ns +- 5 ns: 1.28x slower (+28%)
https://bugs.python.org/issue30156