bpo-28762: Revert last commit (now using Android Unified Headers)#4488
Merged
xdegaye merged 3 commits intopython:masterfrom Nov 23, 2017
xdegaye:bpo-28762
Merged
bpo-28762: Revert last commit (now using Android Unified Headers)#4488xdegaye merged 3 commits intopython:masterfrom xdegaye:bpo-28762
xdegaye merged 3 commits intopython:masterfrom
xdegaye:bpo-28762
Conversation
vstinner
approved these changes
Nov 21, 2017
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, apart the NEWS change.
| .. section: Build | ||
|
|
||
| lockf() is available on Android API level 24, but the F_LOCK macro is not | ||
| defined in android-ndk-r13. |
Member
There was a problem hiding this comment.
Since Python 3.7a1 has been released, I dislike the idea of modying the changelog. Please leave it as it is. Add a new NEWS entry if you want to document the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue28762