Skip to content

bpo-32378: Skip NPN tests with LibreSSL 2.6.1+ #4930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tiran wants to merge 1 commit into from
Closed

bpo-32378: Skip NPN tests with LibreSSL 2.6.1+ #4930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Lib/test/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@
PROTOCOLS = sorted(ssl._PROTOCOL_NAMES)
HOST = support.HOST
IS_LIBRESSL = ssl.OPENSSL_VERSION.startswith('LibreSSL')
if IS_LIBRESSL:
LIBRESSL_VERSION = tuple(
int(s) for s in ssl.OPENSSL_VERSION.rsplit(' ')[-1].split('.')
)
else:
LIBRESSL_VERSION = ()
IS_OPENSSL_1_1 = not IS_LIBRESSL and ssl.OPENSSL_VERSION_INFO >= (1, 1, 0)


Expand Down Expand Up @@ -3392,6 +3398,8 @@ def test_selected_npn_protocol(self):
sni_name=hostname)
self.assertIs(stats['client_npn_protocol'], None)

@unittest.skipIf(IS_LIBRESSL and LIBRESSL_VERSION >= (2, 6, 1),
"LibreSSL 2.6.1+ has broken NPN support")
@unittest.skipUnless(ssl.HAS_NPN, "NPN support needed for this test")
def test_npn_protocols(self):
server_protocols = ['http/1.1', 'spdy/2']
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2017-12-19-20-04-23.bpo-32378.oDT53f.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
LibreSSL 2.6.1+ has broken NPN support, skip tests for now.
4 changes: 2 additions & 2 deletions Tools/ssl/multissltests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@

OPENSSL_RECENT_VERSIONS = [
"1.0.2",
"1.0.2m",
"1.0.2n",
"1.1.0g",
]

Expand All @@ -57,8 +57,8 @@
]

LIBRESSL_RECENT_VERSIONS = [
"2.5.3",
"2.5.5",
"2.6.4",
]

# store files in ../multissl
Expand Down