Skip to content

bpo-32419 Add unittest support for pyc projects, skip news#4998

Closed
brgirgis wants to merge 2 commits intopython:mainfrom
brgirgis:add-pyc-unittest
Closed

bpo-32419 Add unittest support for pyc projects, skip news#4998
brgirgis wants to merge 2 commits intopython:mainfrom
brgirgis:add-pyc-unittest

Conversation

@brgirgis
Copy link

@brgirgis brgirgis commented Dec 23, 2017

This change makes it possible to "unittest" projects that are all pyc with no init.py which is hardcoded in few checks in unittest.loader

https://bugs.python.org/issue32419

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@brgirgis brgirgis changed the title Add unittest support for pyc projects bpo-32419 Add unittest support for pyc projects Dec 23, 2017
@brgirgis brgirgis changed the title bpo-32419 Add unittest support for pyc projects bpo-32419 Add unittest support for pyc projects, skip news Dec 27, 2017
@ned-deily
Copy link
Member

@voidspace, @ezio-melotti, @rbtcollins Any comments on this proposed change? @brgirgis It would be helpful if you added a brief NEWS entry (using blurb) describing the change for users.

@rbtcollins
Copy link
Member

Commenting on the bug tracker - but this doesn't make sense to me per se.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants