Skip to content

bpo-33056 FIX leaking fd in concurrent.futures.ProcessPoolExecutor #6084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asvetlov merged 2 commits into from
Mar 12, 2018
Merged

bpo-33056 FIX leaking fd in concurrent.futures.ProcessPoolExecutor #6084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35971e4
FIX leaking fd in concurrent.futures.ProcessPoolExecutor
tomMoral Mar 12, 2018
a0ba5f2
CLN add NEWS entry
tomMoral Mar 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Lib/concurrent/futures/process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,13 @@


class _ThreadWakeup:
__slot__ = ["_state"]

def __init__(self):
self._reader, self._writer = mp.Pipe(duplex=False)

def close(self):
self._writer.close()
self._reader.close()

def wakeup(self):
self._writer.send_bytes(b"")

Expand Down Expand Up @@ -654,6 +656,11 @@ def shutdown(self, wait=True):
self._call_queue = None
self._result_queue = None
self._processes = None

if self._queue_management_thread_wakeup:
self._queue_management_thread_wakeup.close()
self._queue_management_thread_wakeup = None

shutdown.__doc__ = _base.Executor.shutdown.__doc__

atexit.register(_python_exit)
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2018-03-12-16-40-00.bpo-33056.lNN9Eh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
FIX properly close leaking fds in concurrent.futures.ProcessPoolExecutor.