bpo-23403: Bump pickle.DEFAULT_PROTOCOL to 4#6355
Conversation
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
Please update docstrings, the module documentation, and What's New.
There was a problem hiding this comment.
Since this is a reStructuredText, we can add links: :mod:`pickle`, :pep:`3154`.
|
@pitrou Could you take a look? |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
There is other mention of the default protocol 3 in the module documentation.
Regenerate Argument Clinic files and fix tests.
|
@serhiy-storchaka, updated the remaining comment on default protocol 3, regenerated Argument Clinic. For the failing test, see my comment above, I'm not sure what the fix should be here. |
|
I think there is a bug in C implementation. Opened bpo-33209. |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
And maybe add a versionchanged directive somewhere in pickle.rst?
Doc/library/pickle.rst
Outdated
There was a problem hiding this comment.
Tiny nit: it is preferable to use an en-dash for the version range.
Python 3.0--3.7This makes performance better and produces shorter pickles. This change is backwards compatible up to the oldest currently supported version of Python (3.4).
|
Responded to remaining nits and rebased to include GH-6363. All tests pass now. |
|
@ambv: Please replace |
4 participants
This makes performance better and produces shorter pickles. This change is backwards compatible up to the oldest currently supported version of Python (3.4).
https://bugs.python.org/issue23403