Skip to content

bpo-32911: Remove the docstring attribute of AST types #7121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 4 commits into from
May 29, 2018
Merged

bpo-32911: Remove the docstring attribute of AST types #7121

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
881d59e
Import initial Inada's PR 5927.
serhiy-storchaka May 25, 2018
8ee9227
Remove the DocString AST type.
serhiy-storchaka May 25, 2018
eba9f13
Add a news entry and bump a magic number.
serhiy-storchaka May 28, 2018
4d05ad7
Fix wording.
serhiy-storchaka May 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix wording.
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka committed May 29, 2018
commit 4d05ad71068a8a97fc39f284b3158a8ddb62f2f3
9 changes: 5 additions & 4 deletions Misc/NEWS.d/next/Core and Builtins/2018-02-27-20-57-00.bpo-32911.cmKfco.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
Reverted :issue:`29463`. ``docstring`` field is removed from Module, ClassDef,
FunctionDef, and AsyncFunctionDef ast nodes which is added in 3.7a1. Docstring
expression is restored as a first statement in their body. Based on patch by
Inada Naoki.
Due to unexpected compatibility issues discovered during downstream beta
testing, reverted :issue:`29463`. ``docstring`` field is removed from Module,
ClassDef, FunctionDef, and AsyncFunctionDef ast nodes which was added in
3.7a1. Docstring expression is restored as a first statement in their body.
Based on patch by Inada Naoki.