Skip to content

bpo-32374: Enhance test_importlib.test_bad_traverse() #7147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 1 commit into from
Closed

bpo-32374: Enhance test_importlib.test_bad_traverse() #7147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Lib/test/test_importlib/extension/test_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@

machinery = util.import_importlib('importlib.machinery')

import importlib.util
import os.path
import subprocess
import sys
import types
import unittest
import importlib.util
import importlib
from test.support.script_helper import assert_python_failure

class LoaderTests(abc.LoaderTests):

Expand Down Expand Up @@ -282,7 +281,11 @@ def test_bad_traverse(self):

with support.SuppressCrashReport():
m = spec.loader.create_module(spec)"""
assert_python_failure("-c", script)

proc = subprocess.run([sys.executable, "-c", script])
# Expect a crash: exit code different than 0 (success)
# and 1 (generic Python error).
self.assertNotIn(proc.returncode, [0, 1])


(Frozen_MultiPhaseExtensionModuleTests,
Expand Down