bpo-34217: use lowercase header for windows includes#8453
Merged
methane merged 1 commit intopython:masterfrom Jul 25, 2018
erikjanss:windows-headers-lowercase
Merged
bpo-34217: use lowercase header for windows includes#8453methane merged 1 commit intopython:masterfrom erikjanss:windows-headers-lowercase
methane merged 1 commit intopython:masterfrom
erikjanss:windows-headers-lowercase
Conversation
Contributor
|
Thanks @erikjanss for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
GH-8560 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 30, 2018
(cherry picked from commit 6cf8255) Co-authored-by: erikjanss <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jul 30, 2018
(cherry picked from commit 6cf8255) Co-authored-by: erikjanss <[email protected]>
vmurashev
pushed a commit
to vmurashev/cpython
that referenced
this pull request
Sep 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When cross compiling python on a linux host with a case sensitive file system for a windows target. The compilation will fail due to header
files which contain uppercases.
This commit fixes the case of 2 windows includes.
https://bugs.python.org/issue34217