bpo-34255: Ensure that test.test_embed works when blddir != srcdir#8528
Closed
ronaldoussoren wants to merge 1 commit intopython:masterfrom
Closed
bpo-34255: Ensure that test.test_embed works when blddir != srcdir#8528ronaldoussoren wants to merge 1 commit intopython:masterfrom
ronaldoussoren wants to merge 1 commit intopython:masterfrom
Conversation
This changes the way the _testembed command is located to ensure this helper is found when building outside of the source tree.
Contributor
Author
|
There's a conflict and I'm not sure if the PR is still needed. Therefore closing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title says it all: this patch uses a different way to locate the _testembed helper for test.test_embed to ensure that this tool can be found when building outside of the source directory.
https://bugs.python.org/issue34255