Skip to content

Remove obsolete comment about latin-1 in normalize_encoding#8739

Merged
gpshead merged 1 commit intopython:masterfrom
asottile:patch-1
Sep 11, 2018
Merged

Remove obsolete comment about latin-1 in normalize_encoding#8739
gpshead merged 1 commit intopython:masterfrom
asottile:patch-1

Conversation

@asottile
Copy link
Contributor

@asottile asottile commented Aug 11, 2018

This docstring has drifted since python2:

cpython/Lib/encodings/__init__.py

Line 68 in ca079a3

encoding = encoding.encode('latin-1')

@eamanu
Copy link
Contributor

eamanu commented Aug 12, 2018

Hello @asottile

I don't know if is necessary but the bot say that you have to add a new entry on Misc/NEWS. But for me the change is Ok

@asottile
Copy link
Contributor Author

asottile commented Aug 12, 2018

@eamanu yeah usually for trivial changes like this a core dev will sweep by and add [skip issue] and [skip news] tags (for instance: #7366)

@gpshead gpshead added docs Documentation in the Doc dir skip news skip issue labels Sep 11, 2018
@gpshead gpshead merged commit ed2e9ab into python:master Sep 11, 2018
@asottile asottile deleted the patch-1 branch September 11, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

+1 more reviewer

@eamanu eamanu eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asottile @eamanu @gpshead @the-knights-who-say-ni @bedevere-bot