Remove redundant checks in posixmodule.c#8772
Closed
berkerpeksag wants to merge 1 commit intopython:masterfrom
Closed
Remove redundant checks in posixmodule.c#8772berkerpeksag wants to merge 1 commit intopython:masterfrom
berkerpeksag wants to merge 1 commit intopython:masterfrom
Conversation
Member
|
Sorry, I don't understand why they are redundant. |
Member
Author
|
I was basically following your review comment in #8740 (comment). |
Member
|
The comment in #8740 was about the code that didn't have any effect: if (!return_value) {
goto exit;
}
exit:The code removed in this PR is needed for returning NULL on error. |
Member
Author
|
Ah, now I understand your original comment. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.