bpo-29972: Skip tests known to fail on AIX#979
bpo-29972: Skip tests known to fail on AIX#979vstinner merged 3 commits intopython:masterfrom vstinner:skip_aix
Conversation
On AIX, sigtimedwait(0.2) sleeps 199.8 ms, whereas the test expects 200 ms or longer.
|
@edelsohn: Can you please try this change on AIX? (I'm unable to test my change.) |
Skip some inet_pton() tests of test_socket on AIX. inet_pton() on AIX is less strict than on Linux and doesn't reject some invalid IP addresses. The unit tests test more the libc than Python itself.
|
(Oops, I forgot some "import sys", it should now be fixed.) |
|
With the patches, test_eintr succeed. test_socket fails withFAIL: testIPv6toString (test.test_socket.GeneralModuleTests)Traceback (most recent call last): with a similar guard for the '1:2:3:4:5:6:7:8:' test, it succeeds. test_tools fails because test_tools/test_i18n.py needs to import sys. With that change, it succeeds. |
Lib/test/test_socket.py
Outdated
There was a problem hiding this comment.
'1:2:3:4:5:6:7:8:' needs to be guarded on AIX also.
* test_locale.test_strcoll_with_diacritic() * test_locale.test_strxfrm_with_diacritic() * test_strptime.test_week_of_year_and_day_of_week_calculation() * test_tools.test_POT_Creation_Date()
|
I already added "import sys" to test_tools/test_i18n.py, maybe you picked the old version of my PR?
Ok, done. Can you please test again? |
|
Yes, if with that additional one skipped, it passes.
Thanks David
…On Mon, Apr 3, 2017 at 5:23 PM, Victor Stinner ***@***.***> wrote:
I already added "import sys" to test_tools/test_i18n.py, maybe you picked
the old version of my PR?
'1:2:3:4:5:6:7:8:' needs to be guarded on AIX also.
Ok, done. Can you please test again?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#979 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAowNKjvGmCtIvqFGKMQ8fQAOoWY5VLLks5rsWNQgaJpZM4Mxsms>
.
|
|
Ok, I merged this first changes to fix (skip) a few unit tests on the AIX buildbot. |
3 participants
See http://bugs.python.org/issue29972 for more information.