Merged
Conversation
vstinner
reviewed
Feb 12, 2026
Member
vstinner
left a comment
There was a problem hiding this comment.
Please document the new function in docs/changelog.rst and docs/api.rst.
vstinner
reviewed
Feb 12, 2026
Co-authored-by: Victor Stinner <[email protected]>
vstinner
reviewed
Feb 12, 2026
vstinner
reviewed
Feb 12, 2026
Member
vstinner
left a comment
There was a problem hiding this comment.
I agree to not add Python 3.12 support.
It's tempting to add Python 3.12 support, but Python 3.12 semantics is different:
static inline void _Py_SetImmortal(PyObject *op)
{
if (op) {
op->ob_refcnt = _Py_IMMORTAL_REFCNT;
}
}- Different API: it has no return value (
void)! - It doesn't reject Unicode objects.
- It doesn't untrack objects in the GC.
// Immortal objects were implemented in Python 3.12, however there is no easy API
// to make objects immortal until 3.14 which has _Py_SetImmortal(). Since
// immortal objects are primarily needed for free-threading, this API is implemented
// for 3.14 using _Py_SetImmortal() and uses private macros on 3.13.
I agree that PyUnstable_SetImmortal() is mostly useful on free-threaded builds, so it's ok to skip Python 3.12.
Member
|
Good, the tests passed successfully on Python 3.13 on regular build and free-threaded build:
|
ngoldbaum
reviewed
Feb 12, 2026
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.