collections: fix some Counter nits#7313
Merged
Akuli merged 4 commits intopython:masterfrom Feb 20, 2022
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Okay, looks like the positional-only stuff was changed in python/cpython#20548 |
This comment has been minimized.
This comment has been minimized.
Akuli
reviewed
Feb 20, 2022
stdlib/collections/__init__.pyi
Outdated
| def __ne__(self, other: object) -> bool: ... | ||
| else: | ||
| def __eq__(self, __other: object) -> bool: ... | ||
| def __ne__(self, __other: object) -> bool: ... |
Collaborator
There was a problem hiding this comment.
These don't seem to exist on 3.9, 3.8, 3.7 or 3.6.
Collaborator
Author
There was a problem hiding this comment.
You're right, it inherits them from __dict__.
hauntsaninja
commented
Feb 20, 2022
Akuli
approved these changes
Feb 20, 2022
Collaborator
Akuli
left a comment
Akuli
left a comment
There was a problem hiding this comment.
Please merge when CI passes.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.