Open
Conversation
Member
|
I'm not adding any new shippers without some number of tests. |
Monasca is the OpenStack project for MONitoring At SCAle. Monasca also includes a Logging API that supports centralized logging of logs. The monasca-log-api is a OpenStack based microservice and supports Keystone (Identity Management) based authentication. It provides a secure, reliable and multi-tenant based Logging as a service. The flow is as follows: 1. Using the monsaca log configuration properties, get a token from keystone 2. Cache this token for performance 3. Get the monasca-log-api url from the keystone token service catalog. If the monasca_log_hosts is specified in the config, that would be used instead of the keystone catalog. This config property is a list of host names (or IPs) separated by comma 4. If the hosts list is specified, select a random host and form an url using that 5. Use the log url thus arrived at and open a HTTP connection. If it fails, get another random host. Use retries as well 6. Build the monasca-log-api dimensions, token and content-type (HTTP headers) for the request 7. Send the request to the open HTTP connection (using connection pools to reuse connections where possible) 8. Batch the requests to avoid network overhead and improve throughput Added unit tests and refactored for better readability
Author
|
@josegonzalez sorry about the delay. Have refactored the code and added unit tests. Please review when you get a chance. Thanks. |
Author
|
I'm working on updating the documentation next. |
|
Any chance to get this merged? |
Member
|
Needs docs. |
Member
|
Sorry for the delayed response. Tests should be fixed, feel free to rebase to kick off the tests again. Once docs are added we can get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Monasca is the OpenStack project for MONitoring At SCAle.
Monasca also includes a Logging API that supports centralized
logging of logs. The monasca-log-api is a OpenStack based
microservice and supports Keystone (Identity Management) based
authentication. It provides a secure, reliable and multi-tenant
based Logging as a service.
The flow is as follows:
from keystone
catalog. If the monasca_log_hosts is specified in the config,
that would be used instead of the keystone catalog. This
config property is a list of host names (or IPs) separated by
comma
an url using that
If it fails, get another random host. Use retries as well
(HTTP headers) for the request
pools to reuse connections where possible)
throughput