Skip to content
This repository was archived by the owner on Apr 15, 2024. It is now read-only.

Comments

Fix parmas usage#219

Merged
matusvalo merged 1 commit intopython-consul:masterfrom
sayuan:fix-params
Jul 13, 2018
Merged

Fix parmas usage#219
matusvalo merged 1 commit intopython-consul:masterfrom
sayuan:fix-params

Conversation

@sayuan
Copy link
Contributor

@sayuan sayuan commented Jul 11, 2018

A minor fixed which is the missing changes from #190

@matusvalo
Copy link
Collaborator

matusvalo commented Jul 13, 2018

Thank you @sayuan. I missed this when reviewing #190. I think that we need to bugfix release 1.1.1 with this fix. @cablehead what do you think?

Moreover, I have found some strange params in Event.list() API. I have created new issue for it: #221

@matusvalo matusvalo merged commit 41b7c8c into python-consul:master Jul 13, 2018
@df11
Copy link

df11 commented Oct 24, 2018

I confirm, a bugfix release 1.1.1 would be very useful.
Thanks for the fix

@shamil
Copy link

shamil commented Feb 15, 2019

Yep, seems like 1.1.0 is not useful when loading tokens. Can we have a new release?

@Techcadia
Copy link

Techcadia commented Mar 4, 2019

This is broken in CentOS 7 running Python 2.7.5 rev 76
https://centos.pkgs.org/7/centos-x86_64/python-2.7.5-76.el7.x86_64.rpm.html

as it seems to be upstreamed by someone into the rpm base package.

@matusvalo

mbrulatout referenced this pull request in criteo/py-consul Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants