Updated examples to be PEP compliant#307
Merged
murrayrm merged 12 commits intopython-control:masterfrom Jun 9, 2019
billtubbs:bt-tests
Merged
Updated examples to be PEP compliant#307murrayrm merged 12 commits intopython-control:masterfrom billtubbs:bt-tests
murrayrm merged 12 commits intopython-control:masterfrom
billtubbs:bt-tests
Conversation
Removed MATLAB-like formatting such as semi-colons, syntax and indenting PEP compliant (using PyCharm), changed imports from `from ___ import *` to things like `import matplotlib.pyplot as plt` and `import numpy as np`, removed tabs
murrayrm
reviewed
Jun 8, 2019
examples/pvtol-nested.py
Outdated
| if ax.get_label() == 'control-bode-magnitude': | ||
| break | ||
| ax.semilogx([1e-4, 1e3], 20 * np.log10([1, 1]), 'k-') | ||
| ax.semilogx([1e-4, 1e3], 20*np.log10([1, 1]), 'k-') |
Member
There was a problem hiding this comment.
Should this be indented? It means that it could get executed multiple times?
Contributor
Author
There was a problem hiding this comment.
Oops! I misunderstood that. Will revert it back.
Member
There was a problem hiding this comment.
Looks like this line is still indented and shouldn't be?
Member
|
@billtubbs Did a quick look through the changes. Overall they look good! Some small comments/questions for you to consider, but I think this is fine as is. Will give you a chance to update in case any of the comments resonate, but then we can merge these in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made various edits to all the example scripts including:
printstatements withprint(...)from ___ import *to conventions such asimport matplotlib.pyplot as pltandimport numpy as npOutstanding issues:
np.matrix